Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1966493002: Store scan timestamps with Physical Web URLs (Closed)

Created:
4 years, 7 months ago by cco3
Modified:
4 years, 7 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store scan timestamps with Physical Web URLs This change adds a timestamp to UrlInfo so that we can tell how long ago the URL was last seen. This will permit us to do smarter caching. BUG=598106, 596668 Committed: https://crrev.com/a42232196abfc73d0c710664595af8e1ff01146a Cr-Commit-Position: refs/heads/master@{#392515}

Patch Set 1 #

Patch Set 2 : Update removeUrl to handle differing timestamps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java View 6 chunks +26 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 1 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
cco3
4 years, 7 months ago (2016-05-09 21:21:51 UTC) #2
mattreynolds
lgtm
4 years, 7 months ago (2016-05-09 21:37:42 UTC) #3
cco3
4 years, 7 months ago (2016-05-09 21:41:12 UTC) #5
gone
lgtm
4 years, 7 months ago (2016-05-09 22:30:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966493002/1
4 years, 7 months ago (2016-05-09 22:31:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/67367)
4 years, 7 months ago (2016-05-09 23:41:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966493002/20001
4 years, 7 months ago (2016-05-10 01:09:56 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 02:04:50 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 02:06:03 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a42232196abfc73d0c710664595af8e1ff01146a
Cr-Commit-Position: refs/heads/master@{#392515}

Powered by Google App Engine
This is Rietveld 408576698