Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4291)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

Issue 1966493002: Store scan timestamps with Physical Web URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update removeUrl to handle differing timestamps Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
index fddafeded1efb5b1a42c07a7f995ed150d550195..39af86429c693c969479a2aacf5c08cf42092e20 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
@@ -37,6 +37,7 @@ import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
+import java.util.Iterator;
import java.util.List;
import java.util.Set;
@@ -175,7 +176,7 @@ class UrlManager {
// TODO(conleyo) we should remove this method after calling code only passes us a UrlInfo.
@VisibleForTesting
public void addUrl(String url) {
- addUrl(new UrlInfo(url));
+ addUrl(new UrlInfo(url, -1.0, System.currentTimeMillis()));
}
/**
@@ -188,7 +189,13 @@ class UrlManager {
Log.d(TAG, "URL lost: %s", urlInfo);
boolean isOnboarding = PhysicalWeb.isOnboarding(mContext);
List<UrlInfo> nearbyUrls = getCachedNearbyUrls();
- nearbyUrls.remove(urlInfo);
+ for (Iterator<UrlInfo> iterator = nearbyUrls.iterator(); iterator.hasNext();) {
+ UrlInfo nearbyUrlInfo = iterator.next();
+ if (nearbyUrlInfo.getUrl().equals(urlInfo.getUrl())) {
+ iterator.remove();
+ break;
+ }
+ }
putCachedNearbyUrls(nearbyUrls);
int notificationUrlsAfter = isOnboarding ? nearbyUrls.size() : getUrls().size();
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698