Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1966413002: [battor agent] Move code for stringifying bytes into a util file (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, rnephew (Wrong account)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[battor agent] Move code for stringifying bytes into a util file This will allow us to share code between our unit test (that currently needs this code) and our serial communication logging code (that will soon be written). BUG=611170 Committed: https://crrev.com/cb6f88c99ad2eb4505bac352a14c7df6e866b42a Cr-Commit-Position: refs/heads/master@{#393264}

Patch Set 1 : #

Patch Set 2 : Fixed signed/unsigned char problems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -21 lines) Patch
M tools/battor_agent/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/battor_agent/battor_agent.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/battor_agent/battor_protocol_types_unittest.cc View 1 3 chunks +6 lines, -21 lines 0 comments Download
A tools/battor_agent/serial_utils.h View 1 chunk +20 lines, -0 lines 0 comments Download
A tools/battor_agent/serial_utils.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A tools/battor_agent/serial_utils_unittest.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-05-11 20:22:31 UTC) #5
nednguyen
lgtm
4 years, 7 months ago (2016-05-11 20:23:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966413002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966413002/60001
4 years, 7 months ago (2016-05-11 20:27:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/146541)
4 years, 7 months ago (2016-05-11 21:06:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966413002/100001
4 years, 7 months ago (2016-05-12 15:11:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 7 months ago (2016-05-12 16:20:14 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 16:21:23 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb6f88c99ad2eb4505bac352a14c7df6e866b42a
Cr-Commit-Position: refs/heads/master@{#393264}

Powered by Google App Engine
This is Rietveld 408576698