Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 1970243002: [battor agent] Add option to log serial communication (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@char_array_to_str
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[battor agent] Add option to log serial communication This should help us to identify where we're experiencing problems on the Catapult CQ. BUG=611170 Committed: https://crrev.com/97feb4d0f2448ba8c3e4d0e5b5191a1ecbfb39d2 Cr-Commit-Position: refs/heads/master@{#393547}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added a method to wrap log commands #

Patch Set 3 : Resolved merge conflicts #

Patch Set 4 : Explicitly cast serial::ReceiveError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -9 lines) Patch
M tools/battor_agent/battor_connection_impl.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M tools/battor_agent/battor_connection_impl.cc View 1 2 3 12 chunks +55 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-05-12 15:37:46 UTC) #2
nednguyen
https://codereview.chromium.org/1970243002/diff/1/tools/battor_agent/battor_connection_impl.cc File tools/battor_agent/battor_connection_impl.cc (right): https://codereview.chromium.org/1970243002/diff/1/tools/battor_agent/battor_connection_impl.cc#newcode241 tools/battor_agent/battor_connection_impl.cc:241: << endl; Let create a Log(const string& message) method ...
4 years, 7 months ago (2016-05-12 15:44:29 UTC) #3
charliea (OOO until 10-5)
PTAL
4 years, 7 months ago (2016-05-12 18:56:59 UTC) #4
nednguyen
lgtm
4 years, 7 months ago (2016-05-12 19:48:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970243002/20001
4 years, 7 months ago (2016-05-13 14:12:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/5117) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-13 14:14:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970243002/40001
4 years, 7 months ago (2016-05-13 14:44:13 UTC) #12
commit-bot: I haz the power
Exceeded global retry quota
4 years, 7 months ago (2016-05-13 14:58:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970243002/60001
4 years, 7 months ago (2016-05-13 15:30:34 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-13 16:35:13 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 16:36:45 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/97feb4d0f2448ba8c3e4d0e5b5191a1ecbfb39d2
Cr-Commit-Position: refs/heads/master@{#393547}

Powered by Google App Engine
This is Rietveld 408576698