Issue 1966373002: Revert "Fix strong mode errors in dart:io."

Issue 1966373002: Revert "Fix strong mode errors in dart:io." (Closed)

Created:
4 years, 7 months ago by floitsch

Modified:
4 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Fix strong mode errors in dart:io." This reverts commit 5216f1d67d09d289f7c7ceab56a64ce0dcb7d563. BUG= Committed: https://github.com/dart-lang/sdk/commit/7503ecc8fdb32747b2b05b529219ce83da8f0b6c

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -153 lines)			Patch
M	runtime/bin/directory.cc	View	4 chunks	+19 lines, -20 lines	0 comments	Download
M	runtime/bin/directory_patch.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/bin/io_natives.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_patch.dart	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/bin/stdio_patch.dart	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/io_patch.dart	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	17 chunks	+34 lines, -49 lines	0 comments	Download
M	sdk/lib/io/http_parser.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/io/platform_impl.dart	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	3 chunks	+7 lines, -9 lines	0 comments	Download
M	sdk/lib/io/socket.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	sdk/lib/io/stdio.dart	View	2 chunks	+6 lines, -12 lines	0 comments	Download
M	sdk/lib/io/string_transformer.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	6 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/standalone/io/https_bad_certificate_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

floitsch

Committed patchset #1 (id:1) manually as 7503ecc8fdb32747b2b05b529219ce83da8f0b6c (presubmit successful).

4 years, 7 months ago (2016-05-11 19:44:15 UTC) #4

Message was sent while issue was closed.

LGTM -ip