Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: sdk/lib/io/secure_socket.dart

Issue 1966373002: Revert "Fix strong mode errors in dart:io." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/platform_impl.dart ('k') | sdk/lib/io/socket.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/secure_socket.dart
diff --git a/sdk/lib/io/secure_socket.dart b/sdk/lib/io/secure_socket.dart
index 380a8c466abd282facda77184ed96728b4e0003b..679aa71f0deb28c9f88fcbb4746171cff78aa65f 100644
--- a/sdk/lib/io/secure_socket.dart
+++ b/sdk/lib/io/secure_socket.dart
@@ -415,7 +415,7 @@ class _RawSecureSocket extends Stream<RawSocketEvent>
String _selectedProtocol;
static Future<_RawSecureSocket> connect(
- dynamic/*String|InternetAddress*/ host,
+ host,
int requestedPort,
{bool is_server,
SecurityContext context,
@@ -430,10 +430,8 @@ class _RawSecureSocket extends Stream<RawSocketEvent>
requestClientCertificate, requireClientCertificate,
onBadCertificate);
if (host is InternetAddress) host = host.host;
- InternetAddress address = socket.address;
- if (host != null) {
- address = InternetAddress._cloneWithNewHost(address, host);
- }
+ var address = socket.address;
+ if (host != null) address = address._cloneWithNewHost(host);
return new _RawSecureSocket(address,
requestedPort,
is_server,
@@ -519,10 +517,10 @@ class _RawSecureSocket extends Stream<RawSocketEvent>
}
}
- StreamSubscription<RawSocketEvent> listen(void onData(RawSocketEvent data),
- {Function onError,
- void onDone(),
- bool cancelOnError}) {
+ StreamSubscription listen(void onData(RawSocketEvent data),
+ {Function onError,
+ void onDone(),
+ bool cancelOnError}) {
_sendWriteEvent();
return _stream.listen(onData,
onError: onError,
« no previous file with comments | « sdk/lib/io/platform_impl.dart ('k') | sdk/lib/io/socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698