extensions/renderer/extension_frame_helper.h - Issue 1966283002: Remove port lifetime management from renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extension_frame_helper.h

Issue 1966283002: Remove port lifetime management from renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify: Assume that opener port is open, only send reply if closed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/extension_frame_helper.h

diff --git a/extensions/renderer/extension_frame_helper.h b/extensions/renderer/extension_frame_helper.h

index 57ac3b66b23aafe338929449fc4e16166fa0f072..a2e700846fe12b77e8b1956ff24485484f480bef 100644

--- a/extensions/renderer/extension_frame_helper.h

+++ b/extensions/renderer/extension_frame_helper.h

@@ -95,6 +95,7 @@ class ExtensionFrameHelper

bool OnMessageReceived(const IPC::Message& message) override;

// IPC handlers.

+ void OnExtensionCheckHasMessagePort(int port_id);

void OnExtensionDispatchOnConnect(

int target_port_id,

const std::string& channel_name,

@@ -102,6 +103,7 @@ class ExtensionFrameHelper

const ExtensionMsg_ExternalConnectionInfo& info,

const std::string& tls_channel_id);

void OnExtensionDeliverMessage(int target_port_id,

+ int source_tab_id,

const Message& message);

void OnExtensionDispatchOnDisconnect(int port_id,

const std::string& error_message);