runtime/vm/find_code_object_test.cc - Issue 19662003: Refactor resolution code in the vm to properly handle ambiguity errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/find_code_object_test.cc

Issue 19662003: Refactor resolution code in the vm to properly handle ambiguity errors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/find_code_object_test.cc

===================================================================

--- runtime/vm/find_code_object_test.cc (revision 25321)

+++ runtime/vm/find_code_object_test.cc (working copy)

@@ -53,7 +53,9 @@

source = String::New(scriptChars);

script = Script::New(url, source, RawScript::kScriptTag);

EXPECT(CompilerTest::TestCompileScript(lib, script));

- clsA = lib.LookupClass(String::Handle(Symbols::New("A")));

+ String& ambiguity_error_msg = String::Handle();

+ clsA = lib.LookupClass(String::Handle(Symbols::New("A")),

+ &ambiguity_error_msg);

EXPECT(!clsA.IsNull());

ClassFinalizer::FinalizePendingClasses();

for (int i = 0; i < kNumFunctions; i++) {

@@ -101,7 +103,8 @@

source = String::New(scriptChars);

script = Script::New(url, source, RawScript::kScriptTag);

EXPECT(CompilerTest::TestCompileScript(lib, script));

- clsB = lib.LookupClass(String::Handle(Symbols::New("B")));

+ clsB = lib.LookupClass(String::Handle(Symbols::New("B")),

+ &ambiguity_error_msg);

EXPECT(!clsB.IsNull());

ClassFinalizer::FinalizePendingClasses();

for (int i = 0; i < kNumFunctions; i++) {

« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »