runtime/vm/exceptions.cc - Issue 19662003: Refactor resolution code in the vm to properly handle ambiguity errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.cc

Issue 19662003: Refactor resolution code in the vm to properly handle ambiguity errors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/exceptions.cc

===================================================================

--- runtime/vm/exceptions.cc (revision 25321)

+++ runtime/vm/exceptions.cc (working copy)

@@ -394,7 +394,8 @@

RawInstance* Exceptions::NewInstance(const char* class_name) {

const String& cls_name = String::Handle(Symbols::New(class_name));

const Library& core_lib = Library::Handle(Library::CoreLibrary());

- Class& cls = Class::Handle(core_lib.LookupClass(cls_name));

+ // No ambiguity error expected: passing NULL.

+ Class& cls = Class::Handle(core_lib.LookupClass(cls_name, NULL));

ASSERT(!cls.IsNull());

// There are no parameterized error types, so no need to set type arguments.

return Instance::New(cls);

« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/find_code_object_test.cc » ('j') | no next file with comments »