Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: runtime/vm/resolver_test.cc

Issue 19662003: Refactor resolution code in the vm to properly handle ambiguity errors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/resolver_test.cc
===================================================================
--- runtime/vm/resolver_test.cc (revision 25291)
+++ runtime/vm/resolver_test.cc (working copy)
@@ -102,7 +102,8 @@
static_function_name,
kNumArguments,
Object::empty_array(),
- kResolveType));
+ kResolveType,
+ NULL)); // No ambiguity error expected.
EXPECT(!function.IsNull());
const Array& args = Array::Handle(Array::New(kNumArguments));
const String& arg0 = String::Handle(String::New("junk"));
@@ -123,7 +124,8 @@
static_function_name,
kNumArguments,
Object::empty_array(),
- kResolveType));
+ kResolveType,
+ NULL)); // No ambiguity error expected.
EXPECT(bad_function.IsNull());
}
@@ -139,7 +141,8 @@
super_static_function_name,
kNumArguments,
Object::empty_array(),
- kResolveType));
+ kResolveType,
+ NULL)); // No ambiguity error expected.
EXPECT(!super_function.IsNull());
}
}
@@ -162,7 +165,7 @@
const Library& lib = Library::Handle(Library::LookupLibrary(lib_name));
ASSERT(!lib.IsNull());
const Class& cls = Class::Handle(lib.LookupClass(
- String::Handle(Symbols::New(test_class_name))));
+ String::Handle(Symbols::New(test_class_name)), NULL));
EXPECT(!cls.IsNull());
Instance& receiver = Instance::Handle(Instance::New(cls));
« runtime/vm/parser_test.cc ('K') | « runtime/vm/resolver.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698