Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/snapshot.cc

Issue 19662003: Refactor resolution code in the vm to properly handle ambiguity errors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/parser_test.cc ('K') | « runtime/vm/resolver_test.cc ('k') | tests/language/library_ambiguous_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.cc
===================================================================
--- runtime/vm/snapshot.cc (revision 25291)
+++ runtime/vm/snapshot.cc (working copy)
@@ -212,7 +212,7 @@
library_ = Library::LookupLibrary(str_);
ASSERT(!library_.IsNull());
str_ ^= ReadObjectImpl();
- cls = library_.LookupClass(str_);
+ cls = library_.LookupClass(str_, NULL); // No ambiguity error expected.
cls.EnsureIsFinalized(isolate());
ASSERT(!cls.IsNull());
return cls.raw();
« runtime/vm/parser_test.cc ('K') | « runtime/vm/resolver_test.cc ('k') | tests/language/library_ambiguous_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698