Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: components/arc/arc_bridge_service.h

Issue 1966133002: Run RemoveArcData after a user has opted out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up boolean logic Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_bridge_service.h
diff --git a/components/arc/arc_bridge_service.h b/components/arc/arc_bridge_service.h
index 9fbc6b6183feb6bae94ace2782178213e9775560..bd254797c6c2e295dc1e52d94593bb43a39d4a5e 100644
--- a/components/arc/arc_bridge_service.h
+++ b/components/arc/arc_bridge_service.h
@@ -68,6 +68,8 @@ class ArcBridgeService : public mojom::ArcBridgeHost {
public:
// Called whenever the state of the bridge has changed.
virtual void OnStateChanged(State state) {}
+ virtual void OnBridgeReady() {}
Daniel Erat 2016/05/20 17:41:05 adding these seems strange. why can't observers ju
dspaid 2016/05/23 01:22:36 Luis commented that OnStateChanged was originally
Daniel Erat 2016/05/24 14:51:22 luis, can you add some more details here? is the i
Luis Héctor Chávez 2016/05/24 16:18:28 changing to OnStateChangedForTest SGTM.
dspaid 2016/05/25 00:06:48 Luis, is this something you'll do in the cleanup C
Luis Héctor Chávez 2016/05/25 00:11:01 it's fine to defer for later, just add a TODO for
dspaid 2016/05/25 00:13:27 Done.
+ virtual void OnBridgeStopped() {}
// Called whenever ARC's availability has changed for this system.
virtual void OnAvailableChanged(bool available) {}

Powered by Google App Engine
This is Rietveld 408576698