Run RemoveArcData after a user has opted out

components/arc/arc_bridge_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 #define COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 50 matching lines @@
 
     // The ARC instance has started shutting down.
     STOPPING,
   };
 
   // Notifies life cycle events of ArcBridgeService.
   class Observer {
    public:
     // Called whenever the state of the bridge has changed.
     virtual void OnStateChanged(State state) {}
+    virtual void OnBridgeReady() {}

[Daniel Erat, 2016/05/20 17:41:05]

adding these seems strange. why can't observers just use OnStateChanged() to get
the same information?

[dspaid, 2016/05/23 01:22:36]

Luis commented that OnStateChanged was originally intended for testing and
requested that I add these new methods instead. 

[Daniel Erat, 2016/05/24 14:51:22]

luis, can you add some more details here? is the issue that the only states that
non-test consumers should care about are STOPPED and READY? if so, could you
also rename OnStateChanged to OnStateChangedForTest (if you weren't planning to
do so already)?

[Luis Héctor Chávez, 2016/05/24 16:18:28]

changing to OnStateChangedForTest SGTM.

[dspaid, 2016/05/25 00:06:48]

Luis, is this something you'll do in the cleanup CL you mentioned earlier, or do
you want me to put together another CL for that?  I'd rather not increase the
scope of this CL.

[Luis Héctor Chávez, 2016/05/25 00:11:01]

it's fine to defer for later, just add a TODO for me.

[dspaid, 2016/05/25 00:13:27]

Done.

+    virtual void OnBridgeStopped() {}
 
     // Called whenever ARC's availability has changed for this system.
     virtual void OnAvailableChanged(bool available) {}
 
     // Called whenever the ARC app interface state changes.
     virtual void OnAppInstanceReady() {}
     virtual void OnAppInstanceClosed() {}
 
     // Called whenever the ARC audio interface state changes.
     virtual void OnAudioInstanceReady() {}
@@ skipping 300 matching lines @@
 
   // WeakPtrFactory to use callbacks.
   base::WeakPtrFactory<ArcBridgeService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBridgeService);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_