Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: base/test/test_support_android.cc

Issue 19661004: Made MessagePump a non-thread safe class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding a missing header. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/test_support_android.cc
diff --git a/base/test/test_support_android.cc b/base/test/test_support_android.cc
index e0443227411127d455c7dc65d8cccbf1279b72dc..1ad4c2b0db035c642c459cbbab4e90f5aa606369 100644
--- a/base/test/test_support_android.cc
+++ b/base/test/test_support_android.cc
@@ -72,6 +72,8 @@ class Waitable {
// The MessagePumpForUI implementation for test purpose.
class MessagePumpForUIStub : public base::MessagePumpForUI {
+ virtual ~MessagePumpForUIStub() {}
+
virtual void Start(base::MessagePump::Delegate* delegate) OVERRIDE {
NOTREACHED() << "The Start() method shouldn't be called in test, using"
" Run() method should be used.";
@@ -129,9 +131,6 @@ class MessagePumpForUIStub : public base::MessagePumpForUI {
const base::TimeTicks& delayed_work_time) OVERRIDE {
Waitable::GetInstance()->Signal();
}
-
- protected:
- virtual ~MessagePumpForUIStub() {}
};
base::MessagePump* CreateMessagePumpForUIStub() {
« no previous file with comments | « base/message_loop/message_pump_ozone.h ('k') | chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698