Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4763)

Unified Diff: chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm

Issue 19661004: Made MessagePump a non-thread safe class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding a missing header. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm
index 05304e84dbea61b638442f858ddda2637dbe1bd6..b80a2a8914801d03d4cfb6122fbda3f23494aea0 100644
--- a/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm
@@ -5,6 +5,7 @@
#import "chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h"
#include "base/mac/scoped_nsobject.h"
+#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_pump_mac.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/prefs/pref_service_syncable.h"
@@ -142,7 +143,7 @@ TEST_F(AvatarMenuBubbleControllerTest, PerformLayout) {
@interface TestingAvatarMenuItemController : AvatarMenuItemController
<NSAnimationDelegate> {
@private
- scoped_refptr<base::MessagePumpNSRunLoop> pump_;
+ scoped_ptr<base::MessagePumpNSRunLoop> pump_;
}
// After calling |-highlightForEventType:| an animation will possibly be
// started. Since the animation is non-blocking, the run loop will need to be
@@ -152,8 +153,8 @@ TEST_F(AvatarMenuBubbleControllerTest, PerformLayout) {
@implementation TestingAvatarMenuItemController
- (void)runMessagePump {
- if (!pump_.get())
- pump_ = new base::MessagePumpNSRunLoop;
+ if (!pump_)
+ pump_.reset(new base::MessagePumpNSRunLoop);
pump_->Run(NULL);
}
« no previous file with comments | « base/test/test_support_android.cc ('k') | chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698