Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Issue 19661003: Merged r15267, r15610, r15723, r15724, r15725, r15728 into 3.19 branch. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r15267, r15610, r15723, r15724, r15725, r15728 into 3.19 branch. HBoundsCheck shouldn't ignore Tagged input representations unconditionally HasRealIndexedProperty doesn't work on JSGlobalProxy Synchronize Compare-Literal behavior in FullCodegen and Hydrogen There is no undefined Literal. Fix LiteralCompareTypeof breakage introduced in r15723 Better fix for LiteralCompareTypeof R=jkummerow@chromium.org BUG=v8:2740, chromium:257748, chromium:260345 Committed: http://code.google.com/p/v8/source/detail?r=15799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -110 lines) Patch
M src/ast.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ast.cc View 3 chunks +15 lines, -7 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +22 lines, -69 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-260345.js View 1 chunk +22 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 5 months ago (2013-07-22 11:24:28 UTC) #1
Jakob Kummerow
LGTM, thanks!
7 years, 5 months ago (2013-07-22 11:26:59 UTC) #2
Michael Starzinger
7 years, 5 months ago (2013-07-22 11:32:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698