Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 196603015: [Autofill] Cleanup: Remove the --autofill-service-url flag. (Closed)

Created:
6 years, 9 months ago by Ilya Sherman
Modified:
6 years, 9 months ago
Reviewers:
Jói, Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Autofill] Cleanup: Remove the --autofill-service-url flag. Along the way, clean up some code in the AutofillDownloadManager class. Notably, rename AutofillDownloadManager::AutofillRequestType to just AutofillDownloadManager::RequestType. BUG=352456 TEST=none R=estade@chromium.org TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257273

Patch Set 1 #

Total comments: 2

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -120 lines) Patch
M components/autofill.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_download.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_download.cc View 1 8 chunks +19 lines, -16 lines 0 comments Download
M components/autofill/core/browser/autofill_download_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/autofill/core/browser/autofill_download_url.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/autofill/core/browser/autofill_download_url.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D components/autofill/core/browser/autofill_download_url_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
6 years, 9 months ago (2014-03-14 01:37:51 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/196603015/diff/1/components/autofill/core/browser/autofill_download.cc File components/autofill/core/browser/autofill_download.cc (right): https://codereview.chromium.org/196603015/diff/1/components/autofill/core/browser/autofill_download.cc#newcode50 components/autofill/core/browser/autofill_download.cc:50: "?client=" + kClientName); 4 more indent i think
6 years, 9 months ago (2014-03-14 18:35:47 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 9 months ago (2014-03-14 21:52:50 UTC) #3
Ilya Sherman
TBR Jói for gyp changes (just removing a single line)
6 years, 9 months ago (2014-03-14 21:53:29 UTC) #4
Ilya Sherman
https://codereview.chromium.org/196603015/diff/1/components/autofill/core/browser/autofill_download.cc File components/autofill/core/browser/autofill_download.cc (right): https://codereview.chromium.org/196603015/diff/1/components/autofill/core/browser/autofill_download.cc#newcode50 components/autofill/core/browser/autofill_download.cc:50: "?client=" + kClientName); On 2014/03/14 18:35:47, Evan Stade wrote: ...
6 years, 9 months ago (2014-03-14 21:53:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/196603015/20001
6 years, 9 months ago (2014-03-14 21:55:05 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-15 00:46:53 UTC) #7
Message was sent while issue was closed.
Change committed as 257273

Powered by Google App Engine
This is Rietveld 408576698