Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1966023002: [Sync] Move DataTypeErrorHandler to //sync. (Closed)

Created:
4 years, 7 months ago by maxbogue
Modified:
4 years, 7 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move DataTypeErrorHandler to //sync. SharedModelTypeProcessor will be using this in an upcoming CL. BUG=570085 Committed: https://crrev.com/f8bfa8e182ae83ad9200e0bf969411effaac6653 Cr-Commit-Position: refs/heads/master@{#393061}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix includes. #

Patch Set 3 : Found an unsaved buffer :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -172 lines) Patch
M components/browser_sync/browser/profile_sync_components_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_components_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_typed_url_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.h View 4 chunks +14 lines, -16 lines 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/sync_driver/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/sync_driver/change_processor.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/sync_driver/change_processor.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/sync_driver/change_processor_mock.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M components/sync_driver/data_type_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
D components/sync_driver/data_type_error_handler.h View 1 chunk +0 lines, -38 lines 0 comments Download
D components/sync_driver/data_type_error_handler_mock.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/sync_driver/data_type_error_handler_mock.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M components/sync_driver/fake_generic_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/fake_generic_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/frontend_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/generic_change_processor.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/generic_change_processor.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M components/sync_driver/generic_change_processor_factory.h View 3 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/generic_change_processor_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/non_ui_data_type_controller_unittest.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M components/sync_driver/shared_change_processor.h View 1 2 5 chunks +3 lines, -4 lines 0 comments Download
M components/sync_driver/shared_change_processor.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/sync_driver/shared_change_processor_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/sync_api_component_factory.h View 3 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/sync_api_component_factory_mock.h View 2 chunks +6 lines, -7 lines 0 comments Download
M sync/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
A sync/internal_api/public/data_type_error_handler.h View 1 chunk +37 lines, -0 lines 0 comments Download
A sync/internal_api/public/test/data_type_error_handler_mock.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + sync/internal_api/test/data_type_error_handler_mock.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/sync.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M sync/sync_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
maxbogue
Pavel, PTAL!
4 years, 7 months ago (2016-05-10 21:56:05 UTC) #3
pavely
lgtm with small nits. https://codereview.chromium.org/1966023002/diff/1/components/sync_driver/change_processor.h File components/sync_driver/change_processor.h (right): https://codereview.chromium.org/1966023002/diff/1/components/sync_driver/change_processor.h#newcode13 components/sync_driver/change_processor.h:13: #include "sync/internal_api/public/data_type_error_handler.h" You don't need ...
4 years, 7 months ago (2016-05-11 18:29:05 UTC) #4
maxbogue
https://codereview.chromium.org/1966023002/diff/1/components/sync_driver/change_processor.h File components/sync_driver/change_processor.h (right): https://codereview.chromium.org/1966023002/diff/1/components/sync_driver/change_processor.h#newcode13 components/sync_driver/change_processor.h:13: #include "sync/internal_api/public/data_type_error_handler.h" On 2016/05/11 18:29:04, pavely wrote: > You ...
4 years, 7 months ago (2016-05-11 19:03:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966023002/20001
4 years, 7 months ago (2016-05-11 19:03:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966023002/40001
4 years, 7 months ago (2016-05-11 20:29:15 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-11 21:16:52 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 21:26:15 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f8bfa8e182ae83ad9200e0bf969411effaac6653
Cr-Commit-Position: refs/heads/master@{#393061}

Powered by Google App Engine
This is Rietveld 408576698