[Sync] Move DataTypeErrorHandler to //sync.

components/sync_driver/generic_change_processor.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_H_
 #define COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/non_thread_safe.h"
 #include "components/sync_driver/change_processor.h"
-#include "components/sync_driver/data_type_error_handler.h"
 #include "sync/api/attachments/attachment_store.h"
 #include "sync/api/sync_change_processor.h"
 #include "sync/api/sync_merge_result.h"
 #include "sync/internal_api/public/attachments/attachment_service.h"
 #include "sync/internal_api/public/attachments/attachment_service_proxy.h"
+#include "sync/internal_api/public/data_type_error_handler.h"

[pavely, 2016/05/11 18:29:04]

Could you remove either include or forward-declare?

[maxbogue, 2016/05/11 19:03:02]

Done.

 
 namespace syncer {
+class DataTypeErrorHandler;
 class SyncData;
 class SyncableService;
 class WriteNode;
 class WriteTransaction;
 
 typedef std::vector<syncer::SyncData> SyncDataList;
 }  // namespace syncer
 
 namespace sync_driver {
 
@@ skipping 11 matching lines @@
 class GenericChangeProcessor : public ChangeProcessor,
                                public syncer::SyncChangeProcessor,
                                public syncer::AttachmentService::Delegate,
                                public base::NonThreadSafe {
  public:
   // Create a change processor for |type| and connect it to the syncer.
   // |attachment_store| can be NULL which means that datatype will not use sync
   // attachments.
   GenericChangeProcessor(
       syncer::ModelType type,
-      DataTypeErrorHandler* error_handler,
+      syncer::DataTypeErrorHandler* error_handler,
       const base::WeakPtr<syncer::SyncableService>& local_service,
       const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
       syncer::UserShare* user_share,
       SyncClient* sync_client,
       std::unique_ptr<syncer::AttachmentStoreForSync> attachment_store);
   ~GenericChangeProcessor() override;
 
   // ChangeProcessor interface.
   // Build and store a list of all changes into |syncer_changes_|.
   void ApplyChangesFromSyncModel(
@@ skipping 104 matching lines @@
       attachment_service_weak_ptr_factory_;
   syncer::AttachmentServiceProxy attachment_service_proxy_;
   base::WeakPtrFactory<GenericChangeProcessor> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GenericChangeProcessor);
 };
 
 }  // namespace sync_driver
 
 #endif  // COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_H_