Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 19660002: Revert "[CSS Regions] Mouse over an element does not trigger :hover state for parent when the eleme… (Closed)

Created:
7 years, 5 months ago by eseidel
Modified:
7 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, chromiumbugtracker_adobe.com, leviw+renderwatch, stavila
Visibility:
Public.

Description

Revert "[CSS Regions] Mouse over an element does not trigger :hover state for parent when the element is flowed in a region" This caused :hover on display: block elements to stop working. This reverts commit e1ff7fe9066009c168694766822129ddccb9eac2. BUG=253472 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -833 lines) Patch
D LayoutTests/fast/regions/hover-in-region-grandparent.html View 1 chunk +0 lines, -170 lines 0 comments Download
D LayoutTests/fast/regions/hover-in-region-grandparent-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/regions/hover-in-region-parent-skip-inlines-anonymous.html View 1 chunk +0 lines, -239 lines 0 comments Download
D LayoutTests/fast/regions/hover-in-region-parent-skip-inlines-anonymous-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/regions/hover-on-child-in-region.html View 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/fast/regions/hover-on-child-in-region-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/regions/hover-on-child-in-region-in-region.html View 1 chunk +0 lines, -124 lines 0 comments Download
D LayoutTests/fast/regions/hover-on-child-in-region-in-region-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/regions/hover-on-child-parent-different-regions.html View 1 chunk +0 lines, -125 lines 0 comments Download
D LayoutTests/fast/regions/hover-on-child-parent-different-regions-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
leviw_travelin_and_unemployed
lgtm.
7 years, 5 months ago (2013-07-17 18:24:38 UTC) #1
eseidel
7 years, 5 months ago (2013-07-17 18:25:08 UTC) #2
eseidel
7 years, 5 months ago (2013-07-17 18:25:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r154409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698