runtime/vm/flow_graph_compiler_ia32.cc - Issue 1965823002: Initial isolate reload support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 1965823002: Initial isolate reload support (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index 30cff6b26e89a0fcb551d66aad7cb6123f71214a..64d92a92c753beb70d4acafa2801ebdd5d275b3d 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -446,8 +446,8 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateSubtype1TestCacheLookup(

// ECX: instance class.

// Check immediate superclass equality.

__ movl(EDI, FieldAddress(ECX, Class::super_type_offset()));

- __ movl(EDI, FieldAddress(EDI, Type::type_class_offset()));

- __ CompareObject(EDI, type_class);

+ __ movl(EDI, FieldAddress(EDI, Type::type_class_id_offset()));

+ __ cmpl(EDI, Immediate(Smi::RawValue(type_class.id())));

__ j(EQUAL, is_instance_lbl);

const Register kTypeArgumentsReg = kNoRegister;