runtime/vm/flow_graph_compiler_arm64.cc - Issue 1965823002: Initial isolate reload support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 1965823002: Initial isolate reload support (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_arm64.cc

diff --git a/runtime/vm/flow_graph_compiler_arm64.cc b/runtime/vm/flow_graph_compiler_arm64.cc

index 07cff9ecb8175c5f8989f8429f12d3e00318c905..d0c066e387e63736226338e7fe051cd29cd3feb4 100644

--- a/runtime/vm/flow_graph_compiler_arm64.cc

+++ b/runtime/vm/flow_graph_compiler_arm64.cc

@@ -437,8 +437,8 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateSubtype1TestCacheLookup(

// R1: instance class.

// Check immediate superclass equality.

__ LoadFieldFromOffset(R2, R1, Class::super_type_offset());

- __ LoadFieldFromOffset(R2, R2, Type::type_class_offset());

- __ CompareObject(R2, type_class);

+ __ LoadFieldFromOffset(R2, R2, Type::type_class_id_offset());

+ __ CompareImmediate(R2, Smi::RawValue(type_class.id()));

__ b(is_instance_lbl, EQ);

const Register kTypeArgumentsReg = kNoRegister;