Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1965683002: Add a browser test for UtilityProcessHost. (Closed)

Created:
4 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a browser test for UtilityProcessHost. BUG=597124 Committed: https://crrev.com/dc1c91063493c22633664e04ca52ea4881480068 Cr-Commit-Position: refs/heads/master@{#393126}

Patch Set 1 #

Patch Set 2 : Remove test for elevated processes. #

Patch Set 3 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
A content/browser/utility_process_host_impl_browsertest.cc View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/utility/shell_content_utility_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
Anand Mistry (off Chromium)
This is currently a very basic test. In https://codereview.chromium.org/1893313003/, the test is extended to ensure ...
4 years, 7 months ago (2016-05-10 03:51:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965683002/20001
4 years, 7 months ago (2016-05-10 03:51:44 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/63633)
4 years, 7 months ago (2016-05-10 04:03:06 UTC) #6
Anand Mistry (off Chromium)
-sievers (appears to be inactive) +avi
4 years, 7 months ago (2016-05-11 03:17:19 UTC) #8
Avi (use Gerrit)
lgtm 👍
4 years, 7 months ago (2016-05-11 14:53:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965683002/40001
4 years, 7 months ago (2016-05-11 23:03:26 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 01:00:05 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 01:12:22 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc1c91063493c22633664e04ca52ea4881480068
Cr-Commit-Position: refs/heads/master@{#393126}

Powered by Google App Engine
This is Rietveld 408576698