Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1965613003: Use correct creation context when converting sequences to V8 (Closed)

Created:
4 years, 7 months ago by Jens Widell
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Use correct creation context when converting sequences to V8 The |creationContext| argument is often a reference to a window proxy object, that may become incorrect to use if the frame is navigated and/or detached during the loop that converts values. BUG=607483 Review-Url: https://codereview.chromium.org/1924073003 Cr-Commit-Position: refs/heads/master@{#390408} (cherry picked from commit eb335fd1006cef3299221ebd14a8795679660e32) Committed: https://chromium.googlesource.com/chromium/src/+/29352c3d107adf7fadecf6c5073fa492f1ece220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jens Widell
4 years, 7 months ago (2016-05-10 11:10:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29352c3d107adf7fadecf6c5073fa492f1ece220.

Powered by Google App Engine
This is Rietveld 408576698