Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1924073003: Use correct creation context when converting sequences to V8 (Closed)

Created:
4 years, 7 months ago by Jens Widell
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct creation context when converting sequences to V8 The |creationContext| argument is often a reference to a window proxy object, that may become incorrect to use if the frame is navigated and/or detached during the loop that converts values. BUG=607483 Committed: https://crrev.com/eb335fd1006cef3299221ebd14a8795679660e32 Cr-Commit-Position: refs/heads/master@{#390408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jens Widell
PTAL Noteworthy: this patch changes what frames[0].navigator.languages instanceof Array evaluates to, from true to false, ...
4 years, 7 months ago (2016-04-28 10:47:46 UTC) #2
Yuki
Totally agreed. LGTM.
4 years, 7 months ago (2016-04-28 11:02:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924073003/1
4 years, 7 months ago (2016-04-28 15:30:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 17:05:08 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-04-28 19:21:29 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:19:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb335fd1006cef3299221ebd14a8795679660e32
Cr-Commit-Position: refs/heads/master@{#390408}

Powered by Google App Engine
This is Rietveld 408576698