Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1965563003: Update dart:convert and dart:core Uri. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
floitsch, sra, sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update dart:convert and dart:core Uri. I started trying to get the convert tests all cleaned up and passing but realized I was going down a rathole. So, for now, all of the slow or failing ones are just skipped. BUG= R=sra@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d5a6f16f7ee9ee4f3b2b2442439e196fc1c7f852

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10647 lines, -1148 lines) Patch
M karma.conf.js View 1 chunk +2 lines, -1 line 0 comments Download
M lib/runtime/dart_sdk.js View 90 chunks +1727 lines, -445 lines 0 comments Download
M test/browser/language_tests.js View 5 chunks +48 lines, -23 lines 1 comment Download
A test/codegen/lib/convert/ascii_test.dart View 1 chunk +160 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/base64_test.dart View 1 chunk +287 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/base64_test_01_multi.dart View 1 chunk +288 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/base64_test_none_multi.dart View 1 chunk +288 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion1_test.dart View 1 chunk +256 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion2_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_json_decode1_test.dart View 1 chunk +161 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_json_encode1_test.dart View 1 chunk +79 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf82_test.dart View 1 chunk +155 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf83_test.dart View 1 chunk +79 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf84_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf85_test.dart View 1 chunk +99 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf86_test.dart View 1 chunk +129 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf87_test.dart View 1 chunk +154 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf88_test.dart View 1 chunk +249 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf89_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/chunked_conversion_utf8_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/close_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/codec1_test.dart View 1 chunk +73 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/codec2_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/encoding_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/html_escape_test.dart View 1 chunk +88 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_chunk_test.dart View 1 chunk +173 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_lib_test.dart View 1 chunk +188 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_pretty_test.dart View 1 chunk +116 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_test.dart View 1 chunk +328 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_toEncodable_reviver_test.dart View 1 chunk +55 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_unicode_tests.dart View 1 chunk +77 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_utf8_chunk_test.dart View 1 chunk +450 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/json_util_test.dart View 1 chunk +178 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/latin1_test.dart View 1 chunk +158 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/line_splitter_test.dart View 1 chunk +218 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/streamed_conversion_json_decode1_test.dart View 1 chunk +99 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/streamed_conversion_json_encode1_test.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/streamed_conversion_json_utf8_decode_test.dart View 1 chunk +83 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/streamed_conversion_json_utf8_encode_test.dart View 1 chunk +53 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/streamed_conversion_utf8_decode_test.dart View 1 chunk +66 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/streamed_conversion_utf8_encode_test.dart View 1 chunk +61 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/unicode_tests.dart View 1 chunk +105 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/utf82_test.dart View 1 chunk +140 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/utf83_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/utf84_test.dart View 1 chunk +440 lines, -0 lines 0 comments Download
A + test/codegen/lib/convert/utf85_test.dart View 1 chunk +7 lines, -12 lines 0 comments Download
A test/codegen/lib/convert/utf8_encode_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A test/codegen/lib/convert/utf8_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M test/codegen_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/convert/ascii.dart View 3 chunks +4 lines, -3 lines 0 comments Download
A tool/input_sdk/lib/convert/base64.dart View 1 chunk +752 lines, -0 lines 0 comments Download
M tool/input_sdk/lib/convert/byte_conversion.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/convert/chunked_conversion.dart View 4 chunks +76 lines, -15 lines 0 comments Download
M tool/input_sdk/lib/convert/convert.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/convert/converter.dart View 3 chunks +16 lines, -12 lines 0 comments Download
M tool/input_sdk/lib/convert/encoding.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M tool/input_sdk/lib/convert/html_escape.dart View 3 chunks +165 lines, -34 lines 0 comments Download
M tool/input_sdk/lib/convert/json.dart View 20 chunks +112 lines, -83 lines 0 comments Download
M tool/input_sdk/lib/convert/latin1.dart View 3 chunks +33 lines, -11 lines 0 comments Download
M tool/input_sdk/lib/convert/line_splitter.dart View 2 chunks +111 lines, -45 lines 0 comments Download
M tool/input_sdk/lib/convert/string_conversion.dart View 6 chunks +11 lines, -11 lines 0 comments Download
M tool/input_sdk/lib/convert/utf.dart View 7 chunks +15 lines, -6 lines 0 comments Download
M tool/input_sdk/lib/core/core.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tool/input_sdk/lib/core/uri.dart View 56 chunks +1361 lines, -415 lines 0 comments Download
M tool/input_sdk/patch/convert_patch.dart View 6 chunks +13 lines, -6 lines 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 2 chunks +42 lines, -1 line 0 comments Download
A tool/make_debug_pages.dart View 1 chunk +75 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +22 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Bob Nystrom
4 years, 7 months ago (2016-05-10 00:35:54 UTC) #2
Bob Nystrom
4 years, 7 months ago (2016-05-10 00:41:58 UTC) #3
Bob Nystrom
4 years, 7 months ago (2016-05-10 00:52:02 UTC) #5
sra1
lgtm
4 years, 7 months ago (2016-05-10 02:08:40 UTC) #7
floitsch
On 2016/05/10 02:08:40, sra1 wrote: > lgtm Could you please upload the tests in their ...
4 years, 7 months ago (2016-05-10 16:36:08 UTC) #8
floitsch
On 2016/05/10 16:36:08, floitsch wrote: > On 2016/05/10 02:08:40, sra1 wrote: > > lgtm > ...
4 years, 7 months ago (2016-05-10 16:36:54 UTC) #9
floitsch
https://codereview.chromium.org/1965563003/diff/1/test/browser/language_tests.js File test/browser/language_tests.js (right): https://codereview.chromium.org/1965563003/diff/1/test/browser/language_tests.js#newcode457 test/browser/language_tests.js:457: // TODO(rnystrom): A lot of the convert tests timeout. ...
4 years, 7 months ago (2016-05-10 16:37:06 UTC) #11
Bob Nystrom
Committed patchset #1 (id:1) manually as d5a6f16f7ee9ee4f3b2b2442439e196fc1c7f852 (presubmit successful).
4 years, 7 months ago (2016-05-10 17:25:47 UTC) #13
Bob Nystrom
On 2016/05/10 17:25:47, Bob Nystrom wrote: > Committed patchset #1 (id:1) manually as > d5a6f16f7ee9ee4f3b2b2442439e196fc1c7f852 ...
4 years, 7 months ago (2016-05-10 17:27:35 UTC) #14
Bob Nystrom
4 years, 7 months ago (2016-05-10 17:28:44 UTC) #15
Message was sent while issue was closed.
On 2016/05/10 16:36:08, floitsch wrote:
> On 2016/05/10 02:08:40, sra1 wrote:
> > lgtm
> 
> Could you please upload the tests in their unmodified state first, so that
it's
> possible to see what changes you did?
> 
> Also, dart:convert is still changing (wasn't strong-mode clean, and it looks
> like we have to take another approach than the one that was (silently)
> introduced).

Oh, crap. Sorry, I didn't see this until after I committed.

I know it's still a moving target, but I figured this would at least get DDC
closer to being in sync. When you land more changes, let me know and I'll roll
those in too.

Powered by Google App Engine
This is Rietveld 408576698