third_party/WebKit/Source/core/events/InputEvent.idl - Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/InputEvent.idl

Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't use |std::unique_ptr<>| with |HeapVector| Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/InputEvent.cpp ('K') | « third_party/WebKit/Source/core/events/InputEvent.cpp ('k') | third_party/WebKit/Source/core/events/InputEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/InputEvent.idl

diff --git a/third_party/WebKit/Source/core/events/InputEvent.idl b/third_party/WebKit/Source/core/events/InputEvent.idl

index ce907c7da35e8500a316002e21782e3f1c6a94fc..872c781a9eb9eb7da16f0a60bc08538ab469a8fe 100644

--- a/third_party/WebKit/Source/core/events/InputEvent.idl

+++ b/third_party/WebKit/Source/core/events/InputEvent.idl

@@ -11,5 +11,6 @@

readonly attribute DOMString inputType;

readonly attribute DOMString data;

readonly attribute boolean isComposing;

- // TODO(chongz): Add 'targetRanges'

+ // TODO(chongz): Return StaticRange.

+ sequence<Range> getRanges();

sof 2016/05/31 18:34:24 Web platform API-atypical for this to be "getRange

dtapuska 2016/05/31 18:37:19 This is done on purpose. This is intended to retur

chongz 2016/05/31 18:41:42 Thanks for the question! Please see dtapuska@'s c

};