third_party/WebKit/Source/core/events/InputEvent.idl - Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/events/InputEvent.idl

Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't use |std::unique_ptr<>| with |HeapVector| Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/events/InputEvent.cpp ('K') | « third_party/WebKit/Source/core/events/InputEvent.cpp ('k') | third_party/WebKit/Source/core/events/InputEventInit.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/editing/input-events.html	5 // https://w3c.github.io/editing/input-events.html

6	6

7 [	7 [

8 Constructor(DOMString type, optional InputEventInit eventInitDict),	8 Constructor(DOMString type, optional InputEventInit eventInitDict),

9 RuntimeEnabled=InputEvent,	9 RuntimeEnabled=InputEvent,

10 ] interface InputEvent : UIEvent {	10 ] interface InputEvent : UIEvent {

11 readonly attribute DOMString inputType;	11 readonly attribute DOMString inputType;

12 readonly attribute DOMString data;	12 readonly attribute DOMString data;

13 readonly attribute boolean isComposing;	13 readonly attribute boolean isComposing;

14 // TODO(chongz): Add 'targetRanges'	14 // TODO(chongz): Return StaticRange.

	15 sequence<Range> getRanges();
	sof 2016/05/31 18:34:24 Web platform API-atypical for this to be "getRange Web platform API-atypical for this to be "getRanges()" and not a readonly \|ranges\| attribute? dtapuska 2016/05/31 18:37:19 This is done on purpose. This is intended to retur Show quoted text On 2016/05/31 18:34:24, sof wrote: > Web platform API-atypical for this to be "getRanges()" and not a readonly > \|ranges\| attribute? This is done on purpose. This is intended to return a StaticRange which will be a snapshot at a given time. If we were to use a variable Ranges then it couldn't be a StaticRange and would have to be a live Range; which has detrimental side-effects to performance and ease of object cloning. chongz 2016/05/31 18:41:42 Thanks for the question! Please see dtapuska@'s c Show quoted text On 2016/05/31 18:34:24, sof wrote: > Web platform API-atypical for this to be "getRanges()" and not a readonly > \|ranges\| attribute? Thanks for the question! Please see dtapuska@'s comments above, and for more details please see my next CL (still working): https://codereview.chromium.org/2022863002/diff/1/third_party/WebKit/Source/c...
15 };	16 };

OLD	NEW