Crash on non-rect win clips

Crash on non-rectangular Windows clips

Windows is the only BitmapPlatformDevice which supports non-
rectangular clips, and appears to not actually use them.
Since the only way to *give* a non-rectangular clip to Windows
requires using long-deprecated functions in the Skia non-public
API, this CL asserts that the code in question is never triggered.

R=reed@google.com,fmalita@chromium.org
BUG=609894
Committed: https://crrev.com/af7b2b7b93c045996a5657ce74da10f9e251d621
Cr-Commit-Position: refs/heads/master@{#392598}

[tomhudson, 2016-05-09 20:44:42]

Description was changed from

==========
NOT FOR COMMIT crash on non-rect win clips

BUG=609894
==========

to

==========
Crash on non-rectangular Windows clips

Windows is the only BitmapPlatformDevice which supports non-
rectangular clips, and appears to not actually use them.
Since the only way to *give* a non-rectangular clip to Windows
requires using long-deprecated functions in the Skia non-public
API, this CL asserts that the code in question is never triggered.

R=reed@google.com,fmalita@chromium.org
BUG=609894
==========

[tomhudson, 2016-05-09 20:44:42]

tomhudson@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[tomhudson, 2016-05-09 20:44:49]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 20:45:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965453002/20001

[tomhudson, 2016-05-09 20:45:59]

PTAL: patch set 1 (just adding an abort()) didn't crash on the debug trybot -
suggesting there are no non-rect clips, and the crash on release looks like an
unrelated WebGL problem with shader compilation.

[reed1, 2016-05-09 20:56:38]

https://codereview.chromium.org/1965453002/diff/20001/skia/ext/bitmap_platfor...
File skia/ext/bitmap_platform_device_win.cc (right):

https://codereview.chromium.org/1965453002/diff/20001/skia/ext/bitmap_platfor...
skia/ext/bitmap_platform_device_win.cc:80: SkASSERT(!"Region clipping is being
deprecated; this shouldn't fire.");
perhaps repeat the above assignment to hrgn (using the rgn bounds)? That way we
won't actually crash if the assert fires

[commit-bot: I haz the power, 2016-05-09 21:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 21:45:23]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-05-09 21:49:31]

lgtm

[tomhudson, 2016-05-10 13:46:21]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-05-10 13:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1965453002/#ps40001
(title: "Mike's suggestion")

[commit-bot: I haz the power, 2016-05-10 13:46:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965453002/40001

[commit-bot: I haz the power, 2016-05-10 14:36:54]

Description was changed from

==========
Crash on non-rectangular Windows clips

Windows is the only BitmapPlatformDevice which supports non-
rectangular clips, and appears to not actually use them.
Since the only way to *give* a non-rectangular clip to Windows
requires using long-deprecated functions in the Skia non-public
API, this CL asserts that the code in question is never triggered.

R=reed@google.com,fmalita@chromium.org
BUG=609894
==========

to

==========
Crash on non-rectangular Windows clips

Windows is the only BitmapPlatformDevice which supports non-
rectangular clips, and appears to not actually use them.
Since the only way to *give* a non-rectangular clip to Windows
requires using long-deprecated functions in the Skia non-public
API, this CL asserts that the code in question is never triggered.

R=reed@google.com,fmalita@chromium.org
BUG=609894
==========

[commit-bot: I haz the power, 2016-05-10 14:36:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-10 14:38:18]

Description was changed from

==========
Crash on non-rectangular Windows clips

Windows is the only BitmapPlatformDevice which supports non-
rectangular clips, and appears to not actually use them.
Since the only way to *give* a non-rectangular clip to Windows
requires using long-deprecated functions in the Skia non-public
API, this CL asserts that the code in question is never triggered.

R=reed@google.com,fmalita@chromium.org
BUG=609894
==========

to

==========
Crash on non-rectangular Windows clips

Windows is the only BitmapPlatformDevice which supports non-
rectangular clips, and appears to not actually use them.
Since the only way to *give* a non-rectangular clip to Windows
requires using long-deprecated functions in the Skia non-public
API, this CL asserts that the code in question is never triggered.

R=reed@google.com,fmalita@chromium.org
BUG=609894

Committed: https://crrev.com/af7b2b7b93c045996a5657ce74da10f9e251d621
Cr-Commit-Position: refs/heads/master@{#392598}
==========

[commit-bot: I haz the power, 2016-05-10 14:38:19]

Patchset 3 (id:??) landed as
https://crrev.com/af7b2b7b93c045996a5657ce74da10f9e251d621
Cr-Commit-Position: refs/heads/master@{#392598}