rebaseline_server: make intermediate JSON specify base urls for diff images

rebaseline_server: make intermediate JSON specify base urls for diff images

BUG=skia:1919, skia:2230
NOTREECHECKS=True
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13830

[epoger, 2014-03-14 16:12:12]

Ready for review at patchset 1.

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
File gm/rebaseline_server/imagepairset_test.py (right):

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepairset_test.py:119: 'baseUrl':
'/static/generated-images/diffs',
The advantage of specifying this within the JSON is: depending on which process
is generating the diffs, the diffs can either be available from a live server.py
instance or in Google Storage (or local disk, or elsewhere).

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results.py:41: REBASELINE_SERVER_SCHEMA_VERSION_NUMBER = 2
Because of the version number bump, I will need to restart the live production
rebaseline server instance after commit.

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:77:
constants.REBASELINE_SERVER_SCHEMA_VERSION_NUMBER) {
Unrelated change while I was in the code: check for schema version number, even
if it's a "partially loaded" message in the JSON

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/view.html:22: Loading results from <a
href="{{resultsToLoad}}">{{resultsToLoad}}</a> ...
Unrelated change while I was in the code: display a link to the raw JSON file we
are loading.

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/view.html:378: <a
href="{{imageSets[constants.KEY__IMAGESETS__SET__WHITEDIFFS][constants.KEY__IMAGESETS__FIELD__BASE_URL]}}/{{getImageDiffRelativeUrl(imagePair)}}"
target="_blank">View Image</a><br/>
Hooray, another limiting assumption in the client side code
("/static/generated-images/whitediffs" as base URL) disappears.

[epoger, 2014-03-14 16:15:35]

P.S. I believe the user experience is identical before and after this change,
but you can try the new one out here if you want: http://172.24.179.183:8888/

[epoger, 2014-03-17 13:32:26]

ping

[rmistry, 2014-03-17 13:48:58]

LGTM with nits

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
File gm/rebaseline_server/imagepairset.py (right):

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepairset.py:50: self._diff_base_url =
'/static/generated-images'
Can we make this a module level constant?

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepairset.py:152: key_base_url: self._diff_base_url +
'/diffs',
Use posixpath.join here instead? and below.

[epoger, 2014-03-17 14:21:36]

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
File gm/rebaseline_server/imagepairset.py (right):

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepairset.py:50: self._diff_base_url =
'/static/generated-images'
On 2014/03/17 13:48:58, rmistry wrote:
> Can we make this a module level constant?

Done.

https://codereview.chromium.org/196533021/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepairset.py:152: key_base_url: self._diff_base_url +
'/diffs',
On 2014/03/17 13:48:58, rmistry wrote:
> Use posixpath.join here instead? and below.

Done.

[epoger, 2014-03-17 14:21:42]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-17 14:21:53]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/196533021/20001

[commit-bot: I haz the power, 2014-03-17 14:22:06]

Change committed as 13830