gm/rebaseline_server/static/constants.js - Issue 196533021: rebaseline_server: make intermediate JSON specify base urls for diff images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/static/constants.js

Issue 196533021: rebaseline_server: make intermediate JSON specify base urls for diff images (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/static/constants.js

diff --git a/gm/rebaseline_server/static/constants.js b/gm/rebaseline_server/static/constants.js

index 8d832f0e0bb80c61295a49b81663f25059076027..87a07752a35522a14b8dce658bded7f4a9253f5c 100644

--- a/gm/rebaseline_server/static/constants.js

+++ b/gm/rebaseline_server/static/constants.js

@@ -34,11 +34,15 @@ module.constant('constants', (function() {

KEY__EXTRACOLUMNHEADERS: 'extraColumnHeaders',

KEY__IMAGEPAIRS: 'imagePairs',

KEY__IMAGESETS: 'imageSets',

- KEY__IMAGESETS__BASE_URL: 'baseUrl',

- KEY__IMAGESETS__DESCRIPTION: 'description',

+ KEY__IMAGESETS__FIELD__BASE_URL: 'baseUrl',

+ KEY__IMAGESETS__FIELD__DESCRIPTION: 'description',

+ KEY__IMAGESETS__SET__DIFFS: 'diffs',

+ KEY__IMAGESETS__SET__IMAGE_A: 'imageA',

+ KEY__IMAGESETS__SET__IMAGE_B: 'imageB',

+ KEY__IMAGESETS__SET__WHITEDIFFS: 'whiteDiffs',

// NOTE: Keep these in sync with ../results.py

- REBASELINE_SERVER_SCHEMA_VERSION_NUMBER: 1,

+ REBASELINE_SERVER_SCHEMA_VERSION_NUMBER: 2,

KEY__EXPECTATIONS__BUGS: 'bugs',

KEY__EXPECTATIONS__IGNOREFAILURE: 'ignore-failure',

KEY__EXPECTATIONS__REVIEWED: 'reviewed-by-human',

« no previous file with comments | « gm/rebaseline_server/server.py ('k') | gm/rebaseline_server/static/loader.js » ('j') | no next file with comments »