Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Unified Diff: Source/modules/webdatabase/AbstractSQLTransaction.h

Issue 196533003: Oilpan: Prepare to move AbstractSQLTransaction and SQLTransaction to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webdatabase/Database.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/AbstractSQLTransaction.h
diff --git a/Source/modules/webdatabase/AbstractSQLTransaction.h b/Source/modules/webdatabase/AbstractSQLTransaction.h
index ba8e9997e5d7971df8c4c82f53d9a52616c1532a..5d15f3ef8e8d5f588cc64229bdca1f4bf8274ef9 100644
--- a/Source/modules/webdatabase/AbstractSQLTransaction.h
+++ b/Source/modules/webdatabase/AbstractSQLTransaction.h
@@ -26,6 +26,7 @@
#ifndef AbstractSQLTransaction_h
#define AbstractSQLTransaction_h
+#include "heap/Handle.h"
#include "modules/webdatabase/SQLTransactionState.h"
#include "wtf/ThreadSafeRefCounted.h"
@@ -33,9 +34,10 @@ namespace WebCore {
class AbstractSQLTransactionBackend;
-class AbstractSQLTransaction : public ThreadSafeRefCounted<AbstractSQLTransaction> {
+class AbstractSQLTransaction : public ThreadSafeRefCountedWillBeGarbageCollectedFinalized<AbstractSQLTransaction> {
public:
virtual ~AbstractSQLTransaction() { }
+ virtual void trace(Visitor*) { }
haraken 2014/03/14 08:53:01 Can this be a pure virtual method? This class has
Erik Corry 2014/03/14 09:07:11 That's a good idea and also means you don't have t
tkent 2014/03/15 17:00:28 Done.
virtual void requestTransitToState(SQLTransactionState) = 0;
« no previous file with comments | « no previous file | Source/modules/webdatabase/Database.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698