Oilpan: Prepare to move AbstractSQLTransaction and SQLTransaction to Oilpan heap.

Source/modules/webdatabase/AbstractSQLTransaction.h

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef AbstractSQLTransaction_h
 #define AbstractSQLTransaction_h
 
+#include "heap/Handle.h"
 #include "modules/webdatabase/SQLTransactionState.h"
 #include "wtf/ThreadSafeRefCounted.h"
 
 namespace WebCore {
 
 class AbstractSQLTransactionBackend;
 
-class AbstractSQLTransaction : public ThreadSafeRefCounted<AbstractSQLTransaction> {
+class AbstractSQLTransaction : public ThreadSafeRefCountedWillBeGarbageCollectedFinalized<AbstractSQLTransaction> {
 public:
     virtual ~AbstractSQLTransaction() { }
+    virtual void trace(Visitor*) { }

[haraken, 2014/03/14 08:53:01]

Can this be a pure virtual method? This class has pure virtual methods only.

[Erik Corry, 2014/03/14 09:07:11]

That's a good idea and also means you don't have to call it from the subclasses
(this is how the plugin works).

[tkent, 2014/03/15 17:00:28]

Done.

 
     virtual void requestTransitToState(SQLTransactionState) = 0;
 
     // Used during initialization only.
     virtual bool hasCallback() const = 0;
     virtual bool hasSuccessCallback() const = 0;
     virtual bool hasErrorCallback() const = 0;
     virtual void setBackend(AbstractSQLTransactionBackend*) = 0;
 };
 
 } // namespace WebCore
 
 #endif // AbstractSQLTransaction_h