Issue 196523006: [DevTools]Abstract Counter and CounterUIBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196523006: [DevTools]Abstract Counter and CounterUIBase (Closed)

Created:
6 years, 9 months ago by Pan

Modified:
6 years, 9 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Currently, Counter and CounterUIBase is tightly coupling with memory counter graph, This CL abstract them, then they can be reused by power counter graph. BUG=None

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -30 lines)			Patch
	M	Source/devtools/front_end/CountersGraph.js	View		5 chunks	+9 lines, -9 lines	0 comments	Download
	M	Source/devtools/front_end/MemoryStatistics.js	View		3 chunks	+39 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Pan

Hi @pfeldman, For reuse Counter and CounterUIBase in https://codereview.chromium.org/104523002/, I think we should make such ...

6 years, 9 months ago (2014-03-17 03:37:52 UTC) #1

pfeldman

I'm sorry, I'll need to look at how to refactor it best.

6 years, 9 months ago (2014-03-24 12:41:46 UTC) #2

pfeldman

On 2014/03/24 12:41:46, pfeldman wrote: > I'm sorry, I'll need to look at how to ...

6 years, 9 months ago (2014-03-24 12:45:14 UTC) #3

pfeldman

Here is my take on it: https://codereview.chromium.org/210053002/

6 years, 9 months ago (2014-03-24 14:54:44 UTC) #4

Pan

6 years, 9 months ago (2014-03-25 05:28:18 UTC) #5

On 2014/03/24 14:54:44, pfeldman wrote:
> Here is my take on it: https://codereview.chromium.org/210053002/

that's super great!
thanks! I will close this CL.
Pan

Expand Messages | Collapse Messages