Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1910)

Unified Diff: Source/devtools/front_end/CountersGraph.js

Issue 196523006: [DevTools]Abstract Counter and CounterUIBase (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/MemoryStatistics.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/CountersGraph.js
diff --git a/Source/devtools/front_end/CountersGraph.js b/Source/devtools/front_end/CountersGraph.js
index 02e96d2c719e3b832cc1e8573aeaf7aae8941dea..110695c0537fffa0c35792be91f86a5f5726385f 100644
--- a/Source/devtools/front_end/CountersGraph.js
+++ b/Source/devtools/front_end/CountersGraph.js
@@ -42,16 +42,16 @@ WebInspector.CountersGraph = function(delegate, model)
/**
* @constructor
- * @extends {WebInspector.CounterUIBase}
+ * @extends {WebInspector.MemoryCounterUIBase}
* @param {!WebInspector.CountersGraph} memoryCountersPane
* @param {string} title
* @param {string} currentValueLabel
* @param {!string} color
- * @param {!WebInspector.MemoryStatistics.Counter} counter
+ * @param {!WebInspector.Counter} counter
*/
-WebInspector.CounterUI = function(memoryCountersPane, title, currentValueLabel, color, counter)
+WebInspector.MemoryCounterUI = function(memoryCountersPane, title, currentValueLabel, color, counter)
{
- WebInspector.CounterUIBase.call(this, memoryCountersPane, title, color, counter)
+ WebInspector.MemoryCounterUIBase.call(this, memoryCountersPane, title, color, counter)
this._range = this._swatch.element.createChild("span");
this._value = memoryCountersPane._currentValuesBar.createChild("span", "memory-counter-value");
@@ -65,7 +65,7 @@ WebInspector.CounterUI = function(memoryCountersPane, title, currentValueLabel,
this.graphYValues = [];
}
-WebInspector.CounterUI.prototype = {
+WebInspector.MemoryCounterUI.prototype = {
reset: function()
{
this._range.textContent = "";
@@ -80,7 +80,7 @@ WebInspector.CounterUI.prototype = {
this._range.textContent = WebInspector.UIString("[%d:%d]", minValue, maxValue);
},
- __proto__: WebInspector.CounterUIBase.prototype
+ __proto__: WebInspector.MemoryCounterUIBase.prototype
}
@@ -111,9 +111,9 @@ WebInspector.CountersGraph.prototype = {
*/
_createCounter: function(uiName, uiValueTemplate, color, protocolName)
{
- var counter = new WebInspector.MemoryStatistics.Counter(protocolName);
+ var counter = new WebInspector.Counter(protocolName);
this._counters.push(counter);
- this._counterUI.push(new WebInspector.CounterUI(this, uiName, uiValueTemplate, color, counter));
+ this._counterUI.push(new WebInspector.MemoryCounterUI(this, uiName, uiValueTemplate, color, counter));
},
/**
@@ -146,7 +146,7 @@ WebInspector.CountersGraph.prototype = {
},
/**
- * @param {!WebInspector.CounterUIBase} counterUI
+ * @param {!WebInspector.MemoryCounterUIBase} counterUI
*/
_drawGraph: function(counterUI)
{
« no previous file with comments | « no previous file | Source/devtools/front_end/MemoryStatistics.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698