[Mac][Material Design] Fix ghosting of cast and other extension icons.

[Mac][Material Design] Fix ghosting of cast and other extension icons.

Chrome Mac uses the ToolbarButton class to add extension buttons to the
toolbar, and calls setImage: to set the button's default image. However
under Material Design the ToolbarButton class sets images for several
states (e.g. hover, pressed) - the result is double-drawing of the
default icon. This cl changes ToolbarButton to store the setImage: icon
in an ivar, which prevents the double-drawing but also makes the icon
accessible for later use.

This cl also fixes a problem where the default icon could be drawn in
a different location for the default state than in the other states,
causing the icon to appear to shift as you mouse over the button.

R=avi@chromium.org
BUG=593796
Committed: https://crrev.com/9a51b633fca04015d122b763fd70ae216f65d30a
Cr-Commit-Position: refs/heads/master@{#392964}

[shrike, 2016-05-11 00:26:12]

PTAL

[Avi (use Gerrit), 2016-05-11 14:57:02]

lgtm

[shrike, 2016-05-11 16:33:04]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-11 16:33:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965193002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965193002/1

[commit-bot: I haz the power, 2016-05-11 17:12:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-11 17:15:00]

Description was changed from

==========
[Mac][Material Design] Fix ghosting of cast and other extension icons.

Chrome Mac uses the ToolbarButton class to add extension buttons to the
toolbar, and calls setImage: to set the button's default image. However
under Material Design the ToolbarButton class sets images for several
states (e.g. hover, pressed) - the result is double-drawing of the
default icon. This cl changes ToolbarButton to store the setImage: icon
in an ivar, which prevents the double-drawing but also makes the icon
accessible for later use.

This cl also fixes a problem where the default icon could be drawn in
a different location for the default state than in the other states,
causing the icon to appear to shift as you mouse over the button.

R=avi@chromium.org
BUG=593796
==========

to

==========
[Mac][Material Design] Fix ghosting of cast and other extension icons.

Chrome Mac uses the ToolbarButton class to add extension buttons to the
toolbar, and calls setImage: to set the button's default image. However
under Material Design the ToolbarButton class sets images for several
states (e.g. hover, pressed) - the result is double-drawing of the
default icon. This cl changes ToolbarButton to store the setImage: icon
in an ivar, which prevents the double-drawing but also makes the icon
accessible for later use.

This cl also fixes a problem where the default icon could be drawn in
a different location for the default state than in the other states,
causing the icon to appear to shift as you mouse over the button.

R=avi@chromium.org
BUG=593796

Committed: https://crrev.com/9a51b633fca04015d122b763fd70ae216f65d30a
Cr-Commit-Position: refs/heads/master@{#392964}
==========

[commit-bot: I haz the power, 2016-05-11 17:15:01]

Patchset 1 (id:??) landed as
https://crrev.com/9a51b633fca04015d122b763fd70ae216f65d30a
Cr-Commit-Position: refs/heads/master@{#392964}