[Mac][Material Design] Fix ghosting of cast and other extension icons.

chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/sdk_forward_declarations.h"
 #import "chrome/browser/ui/cocoa/image_button_cell.h"
 #import "chrome/browser/ui/cocoa/view_id_util.h"
@@ skipping 60 matching lines @@
 
 @synthesize icon = icon_;
 @synthesize style = style_;
 
 - (void)dealloc {
   [icon_ release];
   [super dealloc];
 }
 
 + (void)drawImage:(ToolbarButtonImageRep*)imageRep {
-  // Create the path used for the background fill.
-  NSBezierPath* roundedRectPath =
-      [NSBezierPath bezierPathWithRoundedRect:kMDButtonBounds
-                                      xRadius:2
-                                      yRadius:2];
+  ToolbarButtonImageBackgroundStyle displayStyle = [imageRep style];
 
-  // Determine the fill color.
-  NSColor* fillColor = nil;
-  switch (imageRep.style) {
-    case ToolbarButtonImageBackgroundStyle::HOVER:
-      fillColor = [NSColor colorWithCalibratedWhite:0 alpha:0.08];
-      break;
-    case ToolbarButtonImageBackgroundStyle::HOVER_THEMED:
-      fillColor = [NSColor colorWithCalibratedWhite:1 alpha:0.12];
-      break;
-    case ToolbarButtonImageBackgroundStyle::PRESSED:
-      fillColor = [NSColor colorWithCalibratedWhite:0 alpha:0.12];
-      break;
-    case ToolbarButtonImageBackgroundStyle::PRESSED_THEMED:
-      fillColor = [NSColor colorWithCalibratedWhite:1 alpha:0.16];
-      break;
+  // Non-default styles draw a background.
+  if (displayStyle != ToolbarButtonImageBackgroundStyle::DEFAULT) {
+    // Create the path used for the background fill.
+    const int kCornerRadius = 2;
+    NSBezierPath* roundedRectPath =
+        [NSBezierPath bezierPathWithRoundedRect:kMDButtonBounds
+                                        xRadius:kCornerRadius
+                                        yRadius:kCornerRadius];
+
+    // Determine the fill color.
+    NSColor* fillColor = nil;
+    const CGFloat kEightPercentAlpha = 0.08;
+    const CGFloat kTwelvePercentAlpha = 0.12;
+    const CGFloat kSixteenPercentAlpha = 0.16;
+    switch (displayStyle) {
+      case ToolbarButtonImageBackgroundStyle::HOVER:
+        fillColor = [NSColor colorWithCalibratedWhite:0
+                                                alpha:kEightPercentAlpha];
+        break;
+      case ToolbarButtonImageBackgroundStyle::HOVER_THEMED:
+        fillColor = [NSColor colorWithCalibratedWhite:1
+                                                alpha:kTwelvePercentAlpha];
+        break;
+      case ToolbarButtonImageBackgroundStyle::PRESSED:
+        fillColor = [NSColor colorWithCalibratedWhite:0
+                                                alpha:kTwelvePercentAlpha];
+        break;
+      case ToolbarButtonImageBackgroundStyle::PRESSED_THEMED:
+        fillColor = [NSColor colorWithCalibratedWhite:1
+                                                alpha:kSixteenPercentAlpha];
+        break;
+      case ToolbarButtonImageBackgroundStyle::DEFAULT:
+        NOTREACHED();
+    }
+
+    // Fill the path.
+    [fillColor set];
+    [roundedRectPath fill];
   }
 
-  // Fill the path.
-  [fillColor set];
-  [roundedRectPath fill];
-
   // Center the icon within the button.
   NSSize iconSize = [imageRep.icon size];
   CGFloat iconInset = (kMDButtonBounds.size.width - iconSize.width) / 2;
   NSRect iconDestRect = NSInsetRect(kMDButtonBounds, iconInset, iconInset);
   [imageRep.icon drawInRect:iconDestRect
                    fromRect:NSZeroRect
                   operation:NSCompositeSourceOver
                    fraction:1];
 }
 
@@ skipping 126 matching lines @@
 
   // Create the image from the image rep.
   NSImage* image =
       [[[NSImage alloc] initWithSize:kMDButtonBounds.size] autorelease];
   [image setCacheMode:NSImageCacheAlways];
   [image addRepresentation:imageRep];
 
   return image;
 }
 
+- (NSImage*)image {
+  if (!ui::MaterialDesignController::IsModeMaterial()) {
+    return [super image];
+  }
+  // setImage: stores the image in an ivar.
+  return image_.get();
+}
+
 - (void)setImage:(NSImage*)anImage {
-  [super setImage:anImage];
-  if (ui::MaterialDesignController::IsModeMaterial()) {
-    [self resetButtonStateImages];
+  if (!ui::MaterialDesignController::IsModeMaterial()) {
+    [super setImage:anImage];
+    return;
   }
+
+  // We want to set the default image as the image for kDefaultState. Setting it
+  // as the default image (via setImage:) can cause ghosting from the two
+  // default images being drawn over each other. However we also need to keep
+  // the default image around for resetButtonStateImages, so stick it in an
+  // ivar.
+  image_.reset([anImage retain]);
+  [self resetButtonStateImages];
 }
 
 - (void)resetButtonStateImages {
   DCHECK(ui::MaterialDesignController::IsModeMaterial());
 
   NSImage* normalIcon = nil;
   NSImage* disabledIcon = nil;
 
   gfx::VectorIconId iconId = [self vectorIconId];
   if (iconId == gfx::VectorIconId::VECTOR_ICON_NONE) {
     // If the button does not have a vector icon id (e.g. it's an extension
-    // button), use its image.
-    normalIcon = disabledIcon = [self image];
+    // button), use its image. The hover, etc. images will be created using
+    // imageForIcon:withBackgroundStyle: so do the same for the default image.
+    // If we don't do this, the icon may not appear in the same place as in the
+    // other states, causing the icon to appear to shift as you mouse over the
+    // button.
+    NSImage* defaultImage =
+        [self imageForIcon:[self image]
+              withBackgroundStyle:ToolbarButtonImageBackgroundStyle::DEFAULT];
+    normalIcon = disabledIcon = defaultImage;
   } else {
     // Compute the normal and disabled vector icon colors.
     BOOL isDarkTheme = [[self window] hasDarkTheme];
     const SkColor vectorIconColor = [self vectorIconColor:isDarkTheme];
     CGFloat normalAlpha = isDarkTheme ? 0xCC : 0xFF;
     const SkColor normalColor = SkColorSetA(vectorIconColor, normalAlpha);
     const SkColor disabledColor = SkColorSetA(vectorIconColor, 0x33);
 
     // Create the normal and disabled state icons. These icons are always the
     // same shape but use a different color.
@@ skipping 70 matching lines @@
   // Update the hover and pressed image backgrounds to match the current theme.
   if (ui::MaterialDesignController::IsModeMaterial()) {
     [self resetButtonStateImages];
   }
 }
 
 - (void)windowDidChangeActive {
 }
 
 @end