Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1965183003:
chromeos, GN: make it possible to build many unittests. (Closed)
|
Created:
4 years, 7 months ago by dshwang Modified:
4 years, 7 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionchromeos, GN: make it possible to build many unittests.
My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane.
Committed: https://crrev.com/6e7e9c5d2380362959bb2f5721d1fae4f697e530
Cr-Commit-Position: refs/heads/master@{#394434}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 16 (6 generated)
Description was changed from ========== chromeos, GN: make it possible to build many unittests. My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane. ========== to ========== chromeos, GN: make it possible to build many unittests. My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane. ==========
dongseong.hwang@intel.com changed reviewers: + dpranke@chromium.org, spang@chromium.org
dpranke, could you review? as far as I know, there is not any reasons to prevent chromeos from building unittests.
https://codereview.chromium.org/1965183003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1965183003/diff/1/BUILD.gn#newcode726 BUILD.gn:726: deps += [ "//media/cast:udp_proxy" ] cast has unresolved dependencies issues. ERROR Unresolved dependencies. //:gn_only(//build/toolchain/linux:clang_x64) needs //media/cast:udp_proxy(//build/toolchain/linux:clang_x64)
spang@chromium.org changed reviewers: - spang@chromium.org
lgtm. https://codereview.chromium.org/1965183003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1965183003/diff/1/BUILD.gn#newcode726 BUILD.gn:726: deps += [ "//media/cast:udp_proxy" ] On 2016/05/11 10:07:20, dshwang wrote: > cast has unresolved dependencies issues. > ERROR Unresolved dependencies. > //:gn_only(//build/toolchain/linux:clang_x64) > needs //media/cast:udp_proxy(//build/toolchain/linux:clang_x64) Do you mean that udp_proxy has unresolved dependencies when is_chromeos is true? Should that be fixed?
thx for reviewing https://codereview.chromium.org/1965183003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1965183003/diff/1/BUILD.gn#newcode726 BUILD.gn:726: deps += [ "//media/cast:udp_proxy" ] On 2016/05/13 18:53:54, Dirk Pranke wrote: > On 2016/05/11 10:07:20, dshwang wrote: > > cast has unresolved dependencies issues. > > ERROR Unresolved dependencies. > > //:gn_only(//build/toolchain/linux:clang_x64) > > needs //media/cast:udp_proxy(//build/toolchain/linux:clang_x64) > > Do you mean that udp_proxy has unresolved dependencies when is_chromeos is true? > Should that be fixed? correct. I didn't investigate how to fix it, but it should.
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965183003/1
Message was sent while issue was closed.
Description was changed from ========== chromeos, GN: make it possible to build many unittests. My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane. ========== to ========== chromeos, GN: make it possible to build many unittests. My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== chromeos, GN: make it possible to build many unittests. My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane. ========== to ========== chromeos, GN: make it possible to build many unittests. My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane. Committed: https://crrev.com/6e7e9c5d2380362959bb2f5721d1fae4f697e530 Cr-Commit-Position: refs/heads/master@{#394434} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6e7e9c5d2380362959bb2f5721d1fae4f697e530 Cr-Commit-Position: refs/heads/master@{#394434}
Message was sent while issue was closed.
On 2016/05/18 16:12:01, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/6e7e9c5d2380362959bb2f5721d1fae4f697e530 > Cr-Commit-Position: refs/heads/master@{#394434} This breaks https://codereview.chromium.org/1965183003, I need to revert it.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1992903002/ by stevenjb@chromium.org. The reason for reverting is: This breaks GN: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%... Error: ERROR Unresolved dependencies. //:both_gn_and_gyp(//build/toolchain/cros:clang_target) needs //extensions/shell:app_shell(//build/toolchain/cros:clang_target) .
Message was sent while issue was closed.
On 2016/05/18 18:14:36, stevenjb wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1992903002/ by mailto:stevenjb@chromium.org. > > The reason for reverting is: This breaks GN: > https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%... > > Error: > ERROR Unresolved dependencies. > //:both_gn_and_gyp(//build/toolchain/cros:clang_target) > needs //extensions/shell:app_shell(//build/toolchain/cros:clang_target) > . Sorry for inconvenience. Revert the CL. |
