Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1965133002: [runtime] Minimize runtime call stats overhead when it is disabled. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
ulan, Camillo Bruni
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Minimize runtime call stats overhead when it is disabled. ... by 1) avoiding accessing RuntimeCallStats instance, 2) avoiding calculating address of a counter field, 3) and using statically known pointer to a member counter instead. And in addition some code cleanup. BUG=chromium:596055 LOG=N Committed: https://crrev.com/9cda0abdde0784cf5b5664b2c8a929e00a57075b Cr-Commit-Position: refs/heads/master@{#36162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -77 lines) Patch
M src/arguments.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/counters.h View 3 chunks +31 lines, -30 lines 0 comments Download
M src/counters.cc View 2 chunks +12 lines, -29 lines 0 comments Download
M src/heap/gc-tracer.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M src/vm-state-inl.h View 2 chunks +3 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965133002/1
4 years, 7 months ago (2016-05-10 22:36:41 UTC) #3
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-10 22:37:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 23:09:10 UTC) #7
Camillo Bruni
nice work :) LGTM
4 years, 7 months ago (2016-05-11 08:39:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965133002/1
4 years, 7 months ago (2016-05-11 08:40:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15014)
4 years, 7 months ago (2016-05-11 08:43:20 UTC) #12
ulan
heap lgtm
4 years, 7 months ago (2016-05-11 08:47:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965133002/1
4 years, 7 months ago (2016-05-11 08:48:20 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 08:49:40 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 08:51:34 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cda0abdde0784cf5b5664b2c8a929e00a57075b
Cr-Commit-Position: refs/heads/master@{#36162}

Powered by Google App Engine
This is Rietveld 408576698