Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/vm-state-inl.h

Issue 1965133002: [runtime] Minimize runtime call stats overhead when it is disabled. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/gc-tracer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/vm-state-inl.h
diff --git a/src/vm-state-inl.h b/src/vm-state-inl.h
index c8bd4e80828d92dbe0b5b3ebef211c6a7df409bc..4f001a91068fc69aaf0e8b9f1eae0ea641aeb50c 100644
--- a/src/vm-state-inl.h
+++ b/src/vm-state-inl.h
@@ -64,9 +64,8 @@ ExternalCallbackScope::ExternalCallbackScope(Isolate* isolate, Address callback)
#endif
isolate_->set_external_callback_scope(this);
if (FLAG_runtime_call_stats) {
- RuntimeCallStats* stats = isolate->counters()->runtime_call_stats();
- timer_.Initialize(&stats->ExternalCallback, stats->current_timer());
- stats->Enter(&timer_);
+ RuntimeCallStats::Enter(isolate_, &timer_,
+ &RuntimeCallStats::ExternalCallback);
}
TRACE_EVENT_BEGIN0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"),
"V8.ExternalCallback");
@@ -74,7 +73,7 @@ ExternalCallbackScope::ExternalCallbackScope(Isolate* isolate, Address callback)
ExternalCallbackScope::~ExternalCallbackScope() {
if (FLAG_runtime_call_stats) {
- isolate_->counters()->runtime_call_stats()->Leave(&timer_);
+ RuntimeCallStats::Leave(isolate_, &timer_);
}
isolate_->set_external_callback_scope(previous_scope_);
TRACE_EVENT_END0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"),
« no previous file with comments | « src/heap/gc-tracer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698