Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1964993002: [cleanup] Global variable declarations are never hole initialized (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Global variable declarations are never hole initialized Globals used to be hole-initialized in the case of toplevel legacy const declarations. But now that the only use of legacy const is for sloppy function expression names, we can unconditionally initialize globals to undefined instead of the_hole. Committed: https://crrev.com/bdf8dc42577e25df9cdca0d3db4bc80532ddcbba Cr-Commit-Position: refs/heads/master@{#36151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -49 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 7 months ago (2016-05-10 18:30:51 UTC) #2
Benedikt Meurer
Nice cleanup. LGTM.
4 years, 7 months ago (2016-05-10 18:40:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964993002/1
4 years, 7 months ago (2016-05-10 18:45:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 18:57:54 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 18:59:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdf8dc42577e25df9cdca0d3db4bc80532ddcbba
Cr-Commit-Position: refs/heads/master@{#36151}

Powered by Google App Engine
This is Rietveld 408576698