src/full-codegen/x87/full-codegen-x87.cc - Issue 1964993002: [cleanup] Global variable declarations are never hole initialized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 1964993002: [cleanup] Global variable declarations are never hole initialized (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x87/full-codegen-x87.cc

diff --git a/src/full-codegen/x87/full-codegen-x87.cc b/src/full-codegen/x87/full-codegen-x87.cc

index 47a086886f1362771b28717e95be9c73172a9f91..e9d306a2ca346cb61904e2fb986de4e6af62e21a 100644

--- a/src/full-codegen/x87/full-codegen-x87.cc

+++ b/src/full-codegen/x87/full-codegen-x87.cc

@@ -712,10 +712,9 @@ void FullCodeGenerator::VisitVariableDeclaration(

switch (variable->location()) {

case VariableLocation::GLOBAL:

case VariableLocation::UNALLOCATED:

+ DCHECK(!variable->binding_needs_init());

globals_->Add(variable->name(), zone());

- globals_->Add(variable->binding_needs_init()

- ? isolate()->factory()->the_hole_value()

- : isolate()->factory()->undefined_value(), zone());

+ globals_->Add(isolate()->factory()->undefined_value(), zone());

break;

case VariableLocation::PARAMETER:

« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »