Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1964983002: Turn adjacent out-of-flow sibling reparenters into proper methods. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn adjacent out-of-flow sibling reparenters into proper methods. This will make it possible to gradually move callers of these methods (and the methods themselves) down to LayoutBlockFlow, which is where they belong, since only LayoutBlockFlow may parent floats and out-of-flow objects. BUG=302024 Committed: https://crrev.com/1dbddaaf9bbc74d246a4c4c4f0fc7e4d8ec959d4 Cr-Commit-Position: refs/heads/master@{#392696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 3 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 18:26:58 UTC) #2
eae
Ok, LGTM
4 years, 7 months ago (2016-05-10 18:33:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964983002/1
4 years, 7 months ago (2016-05-10 18:34:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 20:23:01 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 20:25:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dbddaaf9bbc74d246a4c4c4f0fc7e4d8ec959d4
Cr-Commit-Position: refs/heads/master@{#392696}

Powered by Google App Engine
This is Rietveld 408576698