Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1964983002: Turn adjacent out-of-flow sibling reparenters into proper methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 // </div> 274 // </div>
275 // </div> 275 // </div>
276 // </div> 276 // </div>
277 277
278 // Returns the nearest enclosing block (including this block) that contribut es a first-line style to our first line. 278 // Returns the nearest enclosing block (including this block) that contribut es a first-line style to our first line.
279 LayoutBlock* enclosingFirstLineStyleBlock() const; 279 LayoutBlock* enclosingFirstLineStyleBlock() const;
280 // Returns this block or the nearest inner block containing the actual first line. 280 // Returns this block or the nearest inner block containing the actual first line.
281 LayoutBlockFlow* nearestInnerBlockWithFirstLine() const; 281 LayoutBlockFlow* nearestInnerBlockWithFirstLine() const;
282 282
283 protected: 283 protected:
284 // Reparent subsequent or preceding adjacent floating or out-of-flow sibling s into this object.
285 // TODO(mstensho): This belongs in LayoutBlockFlow, but needs to live here u ntil we have been
286 // able to move all callers down to LayoutBlockFlow first.
287 void reparentSubsequentFloatingOrOutOfFlowSiblings();
288 void reparentPrecedingFloatingOrOutOfFlowSiblings();
289
284 void willBeDestroyed() override; 290 void willBeDestroyed() override;
285 291
286 void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&); 292 void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&);
287 293
288 void layout() override; 294 void layout() override;
289 295
290 enum PositionedLayoutBehavior { 296 enum PositionedLayoutBehavior {
291 DefaultLayout, 297 DefaultLayout,
292 LayoutOnlyFixedPositionedObjects, 298 LayoutOnlyFixedPositionedObjects,
293 ForcedLayoutAfterContainingBlockMoved 299 ForcedLayoutAfterContainingBlockMoved
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 // FIXME: This is temporary as we move code that accesses block flow 498 // FIXME: This is temporary as we move code that accesses block flow
493 // member variables out of LayoutBlock and into LayoutBlockFlow. 499 // member variables out of LayoutBlock and into LayoutBlockFlow.
494 friend class LayoutBlockFlow; 500 friend class LayoutBlockFlow;
495 }; 501 };
496 502
497 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 503 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
498 504
499 } // namespace blink 505 } // namespace blink
500 506
501 #endif // LayoutBlock_h 507 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698