Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1964943003: Revert of Make GrGammaEffect have explicit sRGB modes, plus exponential mode. (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
Brian Osman, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make GrGammaEffect have explicit sRGB modes, plus exponential mode. (patchset #4 id:60001 of https://codereview.chromium.org/1954863002/ ) Reason for revert: Shader compilation appears to be failing Original issue's description: > Make GrGammaEffect have explicit sRGB modes, plus exponential mode. > > Convert it to a "standard" FP that just transforms the input color. > > For now, we still infer the sRGB transfer curves from the exponent, > but I'm hoping that eventually SkGammas will provide us with the > exact curve we're supposed to be applying. In any case, this adds > support for doing the inverse transformation, as well, which will > be needed in an upcoming Vulkan YUV change, among other things. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1954863002 > > Committed: https://skia.googlesource.com/skia/+/2139303e4c0a9cbcfac695977a80eb026a9296ab TBR=bsalomon@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3e11da7fa9b7ab26df6d6197c3f6a71d0826c97e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -77 lines) Patch
M src/gpu/GrContext.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/effects/GrGammaEffect.h View 1 chunk +10 lines, -15 lines 0 comments Download
M src/gpu/effects/GrGammaEffect.cpp View 5 chunks +47 lines, -59 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Make GrGammaEffect have explicit sRGB modes, plus exponential mode.
4 years, 7 months ago (2016-05-11 12:17:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964943003/1
4 years, 7 months ago (2016-05-11 12:17:33 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:17:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e11da7fa9b7ab26df6d6197c3f6a71d0826c97e

Powered by Google App Engine
This is Rietveld 408576698