Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 196493002: Accept remote urls as gospel in git_cache. (Closed)

Created:
6 years, 9 months ago by agable
Modified:
6 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Accept remote urls as gospel in git_cache. git_cache rewrites all urls to https://netloc/path when setting them as remote urls. This doesn't work when the remote is actually local on disk, and the "url" is a /path/to/repo. This seems like an unlikely case, but it is leveraged by testing, and it doesn't hurt to support it, so now we do. R=iannucci@chromium.org BUG=261619 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M git_cache.py View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
agable
6 years, 9 months ago (2014-03-12 00:40:42 UTC) #1
iannucci
Please update description (and/or bug) with a 'why'?
6 years, 9 months ago (2014-03-12 00:47:15 UTC) #2
iannucci
other than that, lgtm.
6 years, 9 months ago (2014-03-12 00:47:43 UTC) #3
agable
On 2014/03/12 00:47:43, iannucci wrote: > other than that, lgtm. Done.
6 years, 9 months ago (2014-03-12 00:49:48 UTC) #4
agable
The CQ bit was checked by agable@chromium.org
6 years, 9 months ago (2014-03-12 00:49:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/196493002/1
6 years, 9 months ago (2014-03-12 01:07:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 01:26:02 UTC) #7
commit-bot: I haz the power
Presubmit check for 196493002-1 failed and returned exit status -2001. The presubmit check was hung. ...
6 years, 9 months ago (2014-03-12 01:26:03 UTC) #8
agable
The CQ bit was checked by agable@chromium.org
6 years, 9 months ago (2014-03-12 01:41:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/196493002/1
6 years, 9 months ago (2014-03-12 01:42:06 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 01:43:40 UTC) #11
Message was sent while issue was closed.
Change committed as 256386

Powered by Google App Engine
This is Rietveld 408576698