Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: git_cache.py

Issue 196493002: Accept remote urls as gospel in git_cache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cache.py
diff --git a/git_cache.py b/git_cache.py
index f38b4e9d4dc5be2e511eaf2cee6600172a5d9d95..dfda1d7348f6a1bde6bca63f2fa5c372b69287cd 100755
--- a/git_cache.py
+++ b/git_cache.py
@@ -21,15 +21,6 @@ import subcommand
GIT_EXECUTABLE = 'git.bat' if sys.platform.startswith('win') else 'git'
-def NormalizeUrl(url):
- """Convert a git url to a normalized form."""
- parsed = urlparse.urlparse(url)
- norm_url = 'https://' + parsed.netloc + parsed.path
- if not norm_url.endswith('.git'):
- norm_url += '.git'
- return norm_url
-
-
def UrlToCacheDir(url):
"""Convert a git url to a normalized form for the cache dir path."""
parsed = urlparse.urlparse(url)
@@ -192,7 +183,7 @@ def CMDpopulate(parser, args):
def _config(directory):
RunGit(['config', 'core.deltaBaseCacheLimit', '2g'],
cwd=directory)
- RunGit(['config', 'remote.origin.url', NormalizeUrl(url)],
+ RunGit(['config', 'remote.origin.url', url],
cwd=directory)
RunGit(['config', '--replace-all', 'remote.origin.fetch',
'+refs/heads/*:refs/heads/*'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698