Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1964733002: Clean up unused metrics flag. Logic is in blimp browser instead. (Closed)

Created:
4 years, 7 months ago by Jess
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up unused metrics flag from chrome/browser. I added this flag in https://codereview.chromium.org/1765293002 understanding chrome/browser was used by Blimp engine, but it is not. This logic is handled in blimp/engine instead (https://codereview.chromium.org/1945393002). I am cleaning up the (noop) changes. No behavior change is expected from removing this unused flag. BUG=592757 Committed: https://crrev.com/4cda2a8fb0bc180272cd1be30d1213f83a64a3e8 Cr-Commit-Position: refs/heads/master@{#393312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Jess
I added this flag in https://codereview.chromium.org/1765293002 understanding chrome/browser was used by Blimp engine, but it ...
4 years, 7 months ago (2016-05-11 23:26:48 UTC) #6
Lei Zhang
I defer to Alexei. Happy to stamp as needed.
4 years, 7 months ago (2016-05-11 23:30:08 UTC) #8
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-12 15:35:28 UTC) #9
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-12 16:54:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964733002/1
4 years, 7 months ago (2016-05-12 17:14:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 18:32:33 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 18:34:13 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cda2a8fb0bc180272cd1be30d1213f83a64a3e8
Cr-Commit-Position: refs/heads/master@{#393312}

Powered by Google App Engine
This is Rietveld 408576698