Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: components/metrics/BUILD.gn

Issue 1964733002: Clean up unused metrics flag. Logic is in blimp browser instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Overrides os name in uma metrics log to "Blimp". 6 # Overrides os name in uma metrics log to "Blimp".
7 metrics_use_blimp = false 7 metrics_use_blimp = false
8 } 8 }
9 9
10 # GYP version: components/metrics.gypi:metrics 10 # GYP version: components/metrics.gypi:metrics
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 358
359 if (is_chromeos) { 359 if (is_chromeos) {
360 deps += [ ":leak_detector_unit_tests" ] 360 deps += [ ":leak_detector_unit_tests" ]
361 } 361 }
362 362
363 # These are only used by the blimp team, which has entirely migrated to gn, 363 # These are only used by the blimp team, which has entirely migrated to gn,
364 # so this logic is not replicated in the gyp file. 364 # so this logic is not replicated in the gyp file.
365 if (metrics_use_blimp) { 365 if (metrics_use_blimp) {
366 defines = [ 366 defines = [
367 "OVERRIDE_OS_NAME_TO_BLIMP", 367 "OVERRIDE_OS_NAME_TO_BLIMP",
368 "ENABLE_REPORTING_BLIMP",
369 ] 368 ]
370 } 369 }
371 } 370 }
372 # TODO(GYP): metrics_chromeos 371 # TODO(GYP): metrics_chromeos
OLDNEW
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698