Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 196473013: Add comment for gcc compiler bug work-around for SK_COMPILE_ASSERT. (Closed)

Created:
6 years, 9 months ago by bungeman-skia
Modified:
6 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add comment for gcc compiler bug work-around for SK_COMPILE_ASSERT. If this comment had existed previously, I could have avoided breaking some bots. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=13793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M include/core/SkTypes.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
6 years, 9 months ago (2014-03-13 17:37:29 UTC) #1
bsalomon
On 2014/03/13 17:37:29, bungeman1 wrote: lgtm
6 years, 9 months ago (2014-03-13 17:38:20 UTC) #2
bungeman-skia
6 years, 9 months ago (2014-03-13 17:51:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13793.

Powered by Google App Engine
This is Rietveld 408576698